Kbuild: Convert some deck defines to Kconfig #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasdn
requested review from
krichardsson,
ataffanel,
evoggy,
knmcguire and
tobbeanton
jonasdn
commented
Feb 24, 2022
src/deck/drivers/src/Kconfig
Outdated
Comment on lines
227
to
237
| Use DECK_GPIO_RX2 for CS and SPI3 for spi, this requires | ||
| some hardware intervention. | ||
|
|
There was a problem hiding this comment.
This help text might need improving, @tobbeanton @knmcguire any suggestions?
There was a problem hiding this comment.
How about:
Changes the DECK_GPIO_RX2 for CS and SPI3 for spi.
This requires hardware changes on the deck.
Check out for instructions on the micro SD card deck
product page on bitcraze.io
jonasdn
force-pushed
the
jonasdn/usd_alt_pins_kconfig
branch
from
eaaaaef to
b0ad5e3
Compare
jonasdn
changed the title
jonasdn
force-pushed
the
jonasdn/usd_alt_pins_kconfig
branch
from
b0ad5e3 to
82835c5
Compare
krichardsson
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.